That looks like it’s worth investigating. I’ll let you know how I get on with manually updating some awesomeness 😉

Thanks Mike!

Hi Mike,

Thanks for the reply.

I’m pretty sure Piklist can’t handle this situation with the way frontend forms currently work because it requires the ID of the post you want to edit to be passed to the form in the form of a GET URL param.

I did a bit of sleuthing to see if Piklist generated a different <form> tag, or added an extra post_id field when the GET URL param was present but there wasn’t anything obvious I could see.

With multiple forms on the page I don’t know how you can get the correct ID passed to the form as it is rendered to make sure it POSTs to the right CPT instance.

I’ve tried adding a hidden field in the form PHP file for the ID of the post to update (populated with get_the_id()) but that doesn’t seem to work.

Also, I found the fields aren’t correctly pre-populated with the DB values for the current instance of the CPT. However, I was surprised to discover that by using 'value' => get_post_meta( get_the_ID(), PREFIX . 'accounts_status', true ), in the form PHP file the fields were pre-populated correctly for each instance!

Anyway, here’s the code:

parts/forms/job-edit.php

<?php
/**
 Title: Job List Edit Form
 Method: post
 Message: Job updated
 */

piklist( 'field', array(
		'type'  => 'hidden',
		'scope' => 'post',
		'field' => 'post_type',
		'value' => 'job',
	)
);

piklist( 'field', array(
		'type'  => 'select',
		'field' => PREFIX . 'accounts_status',
		'scope' => 'post_meta',
		'value' => get_post_meta( get_the_id(), PREFIX . 'accounts_status', true ),
		'label' => __( 'Accounts Status', 'core-functionality' ),
		'choices' => array(
			'accounts_quote'   => 'Quote',
			'accounts_hold'    => 'Unpaid Hold',
			'accounts_release' => 'Unpaid Release',
			'accounts_paid'    => 'Paid',
		),
	)
);

piklist( 'field', array(
		'type'  => 'select',
		'field' => PREFIX . 'proof_status',
		'scope' => 'post_meta',
		'value' => get_post_meta( get_the_id(), PREFIX . 'proof_status', true ),
		'label' => __( 'Proof Status', 'core-functionality' ),
		'choices' => array(
			'proof_needed'       => 'Needs Proof',
			'proof_sent'         => 'Proof Sent',
			'proof_not_required' => 'Not Required',
			'proof_approved'     => 'Approved',
		),
	)
);

piklist( 'field', array(
		'type'  => 'select',
		'field' => PREFIX . 'print_status',
		'scope' => 'post_meta',
		'value' => get_post_meta( get_the_id(), PREFIX . 'print_status', true ),
		'label' => __( 'Print Status', 'core-functionality' ),
		'choices' => array(
			'printed_no'      => 'Not Printed',
			'printed_yes'     => 'Printed',
			'printed_reprint' => 'Needs Reprint',
		),
	)
);

piklist( 'field', array(
		'type'  => 'select',
		'field' => PREFIX . 'shipping_status',
		'scope' => 'post_meta',
		'value' => get_post_meta( get_the_id(), PREFIX . 'shipping_status', true ),
		'label' => __( 'Shipping Status', 'core-functionality' ),
		'choices' => array(
			'shipped_no'   => 'Not Shipped',
			'shipped_yes'  => 'Shipped',
			'shipped_part' => 'Part Shipped',
		),
	)
);

piklist( 'field', array(
		'type'  => 'submit',
		'field' => 'submit',
		'value' => 'Update',
	)
);

jobs-list.php (template part)

<?php
/**
 * Render a list of Jobs.
 *
 * @package    Musket
 * @author     WP Musketeer - Dave Dean
 * @link       http://www.wpmusketeer.com
 * @copyright  Dave Dean, Moortor Design Ltd.
 * @license    GPL-2.0+
 */

$args = array(
	'post_type'      => array( 'job' ),
	'posts_per_page' => -1,
	'post_status'    => array( 'processing' ),
	'meta_key'       => PREFIX . 'job_priority',
	'orderby'        => 'meta_value_num',
	'order'          => 'ASC',
);

$jobs = new WP_Query( $args );
?>

<?php //echo do_shortcode( '[piklist_form form="job-edit" add_on="core-functionality"]' ); ?>

<div class="job-board">

	<ul class="job-header-row" id="jobHeaderRow">
		<li>↕</li>
		<li>Contact</li>
		<li>Account Status</li>
		<li>Proof Status</li>
		<li>Print Status</li>
		<li>Shipping Status</li>
		<li>Notes</li>
		<li>Actions</li>
	</ul>

	<ul class="job-list" id="sortableJobList">

		<?php
		if ( $jobs->have_posts() ) {
			while ( $jobs->have_posts() ) : $jobs->the_post();
				$priority = get_post_meta( get_the_ID(), PREFIX . 'job_priority', true );
				$accounts_status = get_post_meta( get_the_ID(), PREFIX . 'accounts_status', true );
				$proof_status = get_post_meta( get_the_ID(), PREFIX . 'proof_status', true );
				$print_status = get_post_meta( get_the_ID(), PREFIX . 'print_status', true );
				$shipping_status = get_post_meta( get_the_ID(), PREFIX . 'shipping_status', true );
				$contact = get_post( $post->{ PREFIX . 'related_contact' } );
				?>
				<li class="job" data-id="<?php echo esc_attr( get_the_ID() ); ?>">
					<div class="job-priority"><?php echo esc_html( $priority ); ?></div>
					<ul class="job-details">
						<li class="job-contact">
							<div class="contact-name"><?php echo esc_html( $contact->post_title ); ?></div>
							<div class="order-number"><?php echo the_title(); ?></div>
						</li>
						<li class="job-accounts-status">
							<?php
							echo esc_html( wpm_get_status_map( $accounts_status ) );
							echo wpm_get_tick_icon_map( $accounts_status );
							?>

						</li>
						<li class="job-proof-status">
							<?php
							echo esc_html( wpm_get_status_map( $proof_status ) );
							echo wpm_get_tick_icon_map( $proof_status );
							?>
						</li>
						<li class="job-print-status">
							<?php
							echo esc_html( wpm_get_status_map( $print_status ) );
							echo wpm_get_tick_icon_map( $print_status );
							?>
						</li>
						<li class="job-shipping-status">
							<?php
							echo esc_html( wpm_get_status_map( $shipping_status ) );
							echo wpm_get_tick_icon_map( $shipping_status );
							?>
						</li>
						<li class="job-notes">
							<?php echo the_excerpt(); ?>
						</li>
						<li class="job-actions">
							<a class="job-edit-button button" data-id="<?php echo esc_attr( get_the_ID() ); ?>" href="javascript:;">Edit</a>
						</li>
					</ul>
					<div class="job-edit-<?php echo esc_attr( get_the_ID() ); ?>">
						<form method="post" action="<?php echo esc_attr( site_url() ); ?>?_post[ID]=<?php echo esc_attr( get_the_ID() ); ?>" enctype="multipart/form-data" id="core_functionality_job_edit" autocomplete="off" data-piklist-form="true" class="piklist-form ">
							<?php piklist::render( 'forms/job-edit' ); ?>
						</form>
					</div>
				</li>
				<?php
			endwhile;
		} else {
			wpm_frontend_notice( 'No jobs found.', 'notice-warning is-dismissable' );
		}
		?>
	</ul>
</div>

<?php
wp_reset_postdata();

You can see I’m adding the <form> tag manually in that example. Without it, no <form> tag renders. I’ve tried different actions for the form but all to no avail.

Actually, the above behaviour may just be perfect for my use-case because I can output the <form> tag myself and make sure it POSTs to a URL that passes the ID as a URL parameter.

Let me test…

Hi Jason,

The code I posted above is how the $job_details array looks now. The fields using the PREFIX constant are all Piklist fields. They are the Piklist fields that always worked inside wp_insert_post() (and still do). They are all simple text fields apart from PREFIX . 'related_contact' which is a dropdown relate field.

The fields I had to pull out of that array, and update separately via update_post_meta() were all radio fields. There is a difference between the above fields that work inside wp_insert_post() and the radio fields (that don’t), which might explain where the bug lies. The radio fields all had default values, whereas the above fields which worked did not.

Here’s an example of how I’m declaring a radio field:

piklist( 'field', array(
		'type'    => 'radio',
		'field'   => PREFIX . 'proof_status',
		'list'    => false,
		'value'   => 'proof_needed',
		'label'   => __( 'Proof Status', 'core-functionality' ),
		'choices' => array(
			'proof_needed'       => 'Needs Proof',
			'proof_sent'         => 'Proof Sent',
			'proof_not_required' => 'Not Required',
			'proof_approved'     => 'Approved',
		),
	)
);

Hmm… Been playing around a bit more. It’s very difficult to debug because it completely crashes the browser tab in Chrome and Safari. On Firefox I’ve found it throws up an error dialogue saying “Unresponsive script: jQuery”.

I take it Piklist is using some JavaScript on frontend forms? In the Firefox inspector I can see piklist.js in the JS resources so I guess something here is clashing with jQuery.

The divs with the Piklist forms are hidden by default. I have some JS that shows them when an edit button is clicked but I’ve completely removed that JS and the problem persists.

Here’s how I’m registering the Job CPT including the custom statuses:

add_filter( 'piklist_post_types', 'wpm_register_post_types' );
/**
 * Register Custom Post Types.
 *
 * @param  array $post_types Existing array of CPTs.
 * @return array             Amended array of CPTs
 */
function wpm_register_post_types( $post_types ) {
	$post_types['job'] = array(
		'labels' => piklist( 'post_type_labels', 'Job' ),
		'public' => true,
		'supports' => array(
			'title',
			'editor',
			'author',
			'comments',
		),
		'menu_icon' => 'dashicons-hammer',
		'show_in_rest' => true,
		'status' => array(
			'draft' => array( 'label' => 'Draft' ),
			'processing' => array( 'label' => 'Processing' ),
			'complete' => array( 'label' => 'Complete' ),
		),
	);

	return $post_types;
}

Also, I notice in the WordPress admin that when you click “Save” on any CPT created with Piklist, the button briefly flashes “Publish” then reverts back to “Save”. Is that normal?

Thanks again,

Dave

Hi Steve,

Thanks for getting back to me. I’m already on the version you linked to. I copy pasted the downloaded directory anyway just to be sure.

Still no success 🙁

Do you have to define a relate field on both CPTs? Currently I’m only defining the relationship on the Job.

Can you tell me what changes I should be seeing in the database so I can better understand what’s supposed to happen and what’s not happening currently?

Cheers,

Dave