Hi @mcmaster,

Thanks for the suggestion. It’s a handy little extractor function for sure. However, when would it ever be a nested array in this scenario? Just seems like an overkill for this simple scenario..

Plus, I don’t like that it adds a level of uncertainty to the expected functionality. Instead of checking, if it is_array(), and then looping through that array until you hit a simple value, I would much rather check for is_int() and abort in all other cases. Because I can’t know what the hell Piklist added into those nested arrays (since they shouldn’t even be arrays to begin with), so even the first values can’t be fully trusted. What if it decides to return an Object or basically anything else, that’s not an int. I can’t trust any of those values.

But for now, given that I know the exact problem, I am just trusting that Piklist will add the right value in the first position, even if it’s in an array, and then I grab that value, after checking with a simple inline ! is_array( $app_settings['max_past_orders_to_show'] ) ? '' : $app_settings['max_past_orders_to_show'] before I use it. But it’s definitely a bug that should be fixed, since there is no reason it should be saved as an array in this situation. It’s just bound to cause problems down the road, when this will be fixed one day.

Hi @Steve,

Piklist settings are saved using the WordPress settings api, which saves all data as an array.

I understand that. My settings page looks something like this:

<?php
/**
 * Title: General
 * Tab: General
 * Setting: app_settings
 * Flow: App Workflow
 **/

piklist( 'field', array(
  'type'        => 'number',
  'field'       => 'sync_frequency',
  'label'       => __( 'Sync Frequency', 'app_domain' ),
  'help'        => __( 'How often do you want to pull data from XYZ Service?', 'app_domain' ),
  'description' => __( 'Set data sync frequency (in minutes). A lower value will lead to a more frequent synchronisation sycle & therefore might use more server resources. If you notice a significant performance impact, try increasing this value.', 'app_domain' ),
  'value'       => 1,
  'columns'     => 3,
  'required'    => true,
  'attributes' => array(
    'min'  => 1,
    'step' => 1,
  ),
  'attributes' => array(
    'required' => 'required', // HTML 5 validation
  ),
  'validate' => array(
    array(
      'type'    => 'limit',
      'options' => array(
        'min' => 1,
      ),
    ),
  ),
) );

piklist( 'field', array(
  'type'        => 'number',
  'field'       => 'max_past_orders_to_show',
  'label'       => __( 'Past Orders to Display', 'app_domain' ),
  'help'        => __( 'Maximum number of Past Orders to display by default.', 'app_domain' ),
  'description' => __( 'Set to 0 to always show all past orders right away. This will also permanently hide "Show All Past Orders" button. ', 'app_domain' ),
  'value'       => 20,
  'columns'     => 3,
  'required'    => true,
  'attributes' => array(
    'min'  => 0,
    'step' => 5,
    'required' => 'required', // HTML 5 validation
  ),
  'validate' => array(
    array(
      'type'    => 'limit',
      'options' => array(
        'min' => 0,
      ),
    ),
  ),
) );

However, when I run var_export( get_option( 'app_settings' ) ); I get:

array (
  'sync_frequency' => '1',
  'max_past_orders_to_show' => array (
    0 => '10',
  ),
)

Why is sync_frequency saved as a string (which could be casted to an int easily, so it’s ok), yet max_past_orders_to_show, which is setup exactly the same way, is saved as an array of strings? It’s so strange. I didn’t set it up to be a repeater field, why is Piklist doing it?

Hi Steve,

Thanks so much for the quick fix (I believe the latest v1.0.2 has addressed this bug):

Merry Christmas,
Alex