- This topic has 9 replies, 3 voices, and was last updated 8 years, 6 months ago by
Marcus.
-
AuthorPosts
-
-
July 16, 2013 at 8:05 pm #904
MarcusMemberI’ve been working with Piklist in WP 3.5.2 for a few days now, and I think I’ve found another new bug. (this may or may not be 3.5.2 only, but I think it is, as I didn’t see it in previous installs)
When you go to the media library and edit any attachment, the following error comes up below:
https://gist.github.com/anonymous/6016351Once I deactivate piklist the error goes away, and piklist is the only plugin in my install.
I tried to debug it, but finding where its coming from is hard. Maybe a new syntax in 3.5.2 for a command in the way plugins are handled in the media functions???
It does state its in the foreach of the includes/media.php (wp media library file) line 1348
With no real way to debug it, as it doesn’t reference any of the piklist commands or files, I can only hope Steve or Kevin can figure this one out. Or maybe the Beta test replaces it. <grin>
Thanks guys.
Marcus
-
July 17, 2013 at 3:45 pm #906
SteveKeymasterhey Marcus– Let us know if the beta fixes your issue >
-
July 17, 2013 at 8:15 pm #912
MarcusMemberSo bummed. Tried all three demos Content Types, Taxonomies and the Piklist Demos in WP 3.5.2 and nothing worked.
Tried with and without errors on, but still nothing worked. A ton of Undefined Index errors.
Will try and go through some later and see what I can fix. But still licking my wounds.
Man it looks exciting though.
Unfortunately can’t regress the install for this latest client, wish I could, but I’m stuck with using 3.5.2Marcus
-
July 17, 2013 at 8:28 pm #913
KevinKeymasterHi Marcus-
Sorry about that, those add-ons aren’t quite ready to play with yet. We will update the beta right away.
Can you give me more detail on your error? I will work on it tonight for ya.
Thanks,
Kevin
-
July 17, 2013 at 9:32 pm #914
MarcusMemberKevin, I tried a completely fast hack on all the errors, and almost have it working properly (all except for the list tables) and add new content type, under advanced labels I’m not sure is working but everything else seems ok.
Also, since my local version is running on windows, there was a pathing issue in class-piklist.php in includes.
Here’s the fixed I made. Works great in 3.5.2 now, so take your time.
Marcus
Piklist Settings Page Error:
(IN)
/piklist/includes/class-piklist-workflow.php
Change line 200:
(FROM)
&& (!$post_type || ($post_type && (($post && $typenow == $post_type) || (!$post && $_REQUEST['post_type'] == $post_type))))(TO)
&& (!$post_type || ($post_type && (($post && $typenow == $post_type) || (!$post && isset($_REQUEST['post_type']) && $_REQUEST['post_type'] == $post_type)))) // EditedWindows Path Error:
(IN)
/piklist/includes/class-piklist.php
Change lines 136-137:
(FROM)self::$paths[$type] = $path; self::$urls[$type] = plugins_url() . substr($path, strrpos($path, '/'));(TO)
self::$paths[$type] = $path; $path = str_replace(chr(92), '/', $path); // Edited (windows path error) self::$urls[$type] = plugins_url() . substr($path, strrpos($path, '/'));Misc Errors:
(IN)
/piklist/includes/class-piklist-form.php
Change line 767:
(FROM)
else if ($wp_taxonomies[$field['field']]->object_type[0] == 'user')(TO)
else if (isset($wp_taxonomies[$field['field']]->object_type[0]) && $wp_taxonomies[$field['field']]->object_type[0] == 'user') // Edited(IN)
/piklist/includes/class-piklist-form.php
Change line 422:
(FROM)
$meta = $meta[$key];(TO)
$meta = isset($meta[$key])?$meta[$key]:0; // Edited(IN)
/piklist/includes/class-piklist-cpt.php
Change line 343:
(FROM)
$post_type = $_REQUEST['post_type'];(TO)
$post_type = isset($_REQUEST['post_type'])?$_REQUEST['post_type']:false; // Edited(IN)
/piklist/includes/class-piklist-list-table.php
Change line 118:
(FROM)
$this->sortable_columns = $sortable_columns;(TO)
$this->sortable_columns = isset($sortable_columns)?$sortable_columns:false; // EditedChange line 125:
(FROM)
,'ajax' => $ajax(TO)
,'ajax' => isset($ajax)?$ajax:false // EditedChange line 78:
(FROM)
,'export' => $export(TO)
,'export' => isset($export)?$export:true // EditedMade a guess on var types when setting them.
Pretty sure I’m wrong, but didn’t take time to check. LOLMarcus
-
July 17, 2013 at 9:47 pm #915
MarcusMemberAlso: (just tried to activate my old piklist meta-boxes, produced errors)
(IN)
/piklist/includes/class-piklist/cpt.php
Change line 457:
(FROM)
$textdomain = piklist_add_on::$available_add_ons[$add_on]['TextDomain'];(TO)
$textdomain = isset(piklist_add_on::$available_add_ons[$add_on]['TextDomain'])?piklist_add_on::$available_add_ons[$add_on]['TextDomain']:false; // EditedHope it helps someone.
Marcus
-
July 17, 2013 at 10:01 pm #916
MarcusMemberSorry buddy, I gotta leave it up to the pro.
I just tried to create a new taxonomy and the errors that came out were amazing.
I lost count after the wordpress function errors showed up.
Sorry to say, I’d love to help on this one, but I think the demos are best left to the professional.
Hope you manage to find them all. Their nasty little critters. 🙂
Marcus
-
July 17, 2013 at 10:04 pm #917
MarcusMemberBy the way, Steve, the error when editing a media attachment is now gone. 🙂
Marcus
-
July 17, 2013 at 10:15 pm #918
KevinKeymasterHi Marcus-
Thanks for the intel. As for the add-ons, please ignore them. Those are outdated early versions that were accidentally pushed today, you will get to see the real deal here shortly 😉 We should have another update either tomorrow or friday with some fixes and we will be updating very often now.
Thanks,
Kevin
PS If your up for it I can send you my skype or aim account and we can work through some of your issues whilst I debug, let me know.
-
July 17, 2013 at 10:30 pm #919
MarcusMemberKevin would love too.
I take it you guys have my contact info in your admin.
Please send me an email and I’ll send you my skype.
Marcus
-
-
AuthorPosts
- You must be logged in to reply to this topic.