Tagged: ,

Viewing 3 reply threads
  • Author
    Posts
    • October 14, 2013 at 6:51 pm #1157
      Marcus
      Member

      Noticed you were making Piklist very universal so that it will work in almost any type of installation, but found a couple places where you forgot to replace content_url with WP_PLUGIN_URL (such as my local install, which has a different named plugins dir)

      In file: includes/class-piklist-shortcode.php
      Line 37 should read:


      $plugins['piklist_shortcode'] = WP_PLUGIN_URL . '/piklist/parts/js/piklist-tinymce-shortcode.js';

      And in file: includes/class-piklist-form.php
      Lines 240 and 241 should read:


      wp_register_style('jquery-ui-core', WP_PLUGIN_URL . '/piklist/parts/css/jquery-ui/jquery-ui.smoothness.css', false, $jquery_ui_core->ver);
      wp_register_script('jquery-timepicker', WP_PLUGIN_URL . '/piklist/parts/js/jquery.timePicker.min.js', array('jquery'), '0.1', true);

      Hope that helps.

      Great to see you guys growing the userbase. I’ll be using Piklist more and more in the future.

      Marcus

    • October 15, 2013 at 9:20 am #1158
      Steve
      Keymaster

      Thanks, Marcus. Both will be replaced with content_url() in the next release. Glady you enjoy using Piklist. Please let us know how you are using it.

    • October 16, 2013 at 3:08 am #1159
      Marcus
      Member

      Sorry Steve I should have been clearer. It was originally content_url();
      Old lines: 

      content_url() . '/plugins/piklist/parts/js/jquery

      Which means the plugins path was hardcoded, if someone has changed the name of their plugins directory it wouldn’t work.

      Changed it to:

      WP_PLUGIN_URL . '/piklist/parts/js/jquery

      And everythings fine now.

      Things are great, using piklist and wordpress to help a private school redevelop their website, ecommerce, staffing, data storage infrastructure, reporting, marketing, etc. Should be a 4 year project, starting with an 8 month phase 1 contract.

      Very excited about this client. They want some pretty cutting edge stuff.

      Marcus

    • October 16, 2013 at 2:54 pm #1160
      Steve
      Keymaster

      Hey Marcus–

      The issue with using the WP_PLUGIN_URL constant is that it doesn’t respect HTTPS.

      Try using the piklist::$urls['piklist'] function instead:

      $plugins['piklist_shortcode'] = piklist::$urls['piklist'] . '/parts/js/piklist-tinymce-shortcode.js';

      We tested locally and it seems to work great.

  • Author
    Posts
Viewing 3 reply threads
  • You must be logged in to reply to this topic.