- This topic has 2 replies, 2 voices, and was last updated 7 years, 8 months ago by
.
-
Posts
-
-
Just FYI I received this email today regarding my plugin submission ..
We cannot accept a plugin that includes an entire other plugin, wholesale, inside it. Yours included Piklist. While we understand the use of framework (or boilerplate) plugins, and encourage the use of common libraries, full blown plugins should never be included inside another, as it causes multiple potential issues, such as function/attribute conflicts, and also opens your code up for issues should the included plugin be closed for a security hole. The proper way to include another plugin would be to require it in your own. You can use the hook is_plugin_active() to check to see if the plugin is, indeed, installed and active. https://codex.wordpress.org/Function_Reference/is_plugin_active The other alternative would be to actually fork the code, and not have a 100% copy in yours. Sadly, WordPress plugins don't have the ability to do sub-modules, so you'll have to actually customize the code for interaction. When you've corrected your code, reply to this email with the updated code attached as a zip, or provide a link to the new code for us to review.While I understand the recommendation is to use the custom file that checks for Piklist, but as I mentioned in another thread, I do not want the users to have to deal with anything in regards to installing/updating/maintaining piklist, so my plan was to just include it in the plugin.
Unfortunately WP doesn’t like this too much, and wanted to post this here in case anybody wanted to do this, as had I known this before, I probably would have not used Piklist on this plugin 🙁
Now it’s time to remove files and see what I can eliminate to make them accept it … hmmm
-
@tripflex– This is a very cool plugin and it looks like it has lots of potential. Unfortunately, Piklist was never intended to be included in a plugin or theme. Your post has prompted us to write an article on why we don’t love the idea. I hope once you read it you will agree and resubmit your plugin to WordPress.org without Piklist included.
Always happy to discuss this further.
-
@steve as always, thanks for the quick response. I understand Piklist was not intended to be included with plugins or themes as a framework, but because of how fond I was of it I wanted to give it a try on this plugin.
Unfortunately the way I was looking at it was as using it in a framework sense, as I planned on making some modifications further down the road to the core of piklist as needed, and didn’t want to worry about issues when users upgrade.
That’s okay though, because i’ve already wrote most of my code using it, i’ll just have to work on slimming down the version of piklist I use, and start customizing everything. Luckily PHPStorm does a very good job of refactoring so it shouldn’t be a problem to change things around to ensure no issues if they do install Piklist as a plugin itself.
Maybe that’s what i’ll try and work on, a “module” shall we say of piklist slimmed down, sort of like how you can customize the features you need in bootstrap and download that version. Maybe setup a github repo that allows you to do something similar and uses a specific namespace or changes classes to match plugin … hmmm hmmmm … I guess the real question is how modular is Piklist 😛
Either way I still love Piklist and if it was for a theme or customer I was doing this for, I would have no problem using the default plugin. My worry is with further down the road, if I end up being restricted by what can be done (ie customize options pages more, etc), I want to have full control over piklist so I can modify core code if needed to add features or change things around…or heavens forbid the project gets abandoned (which i doubt it will), I just don’t want the plugin to rely on something I have no control over.
I completely understand where you guys are coming from and hopefully this explains where i’m coming from as well … i’m just thinking worst case scenario because something similar has happened to me in the past, and I would hate to have to go through those heartaches all over again.
If I do come up with something i’ll be sure to post it here and let you guys know! Thanks for all your hard work so far!
-
- You must be logged in to reply to this topic.