#914
Marcus
Member

Kevin, I tried a completely fast hack on all the errors, and almost have it working properly (all except for the list tables) and add new content type, under advanced labels I’m not sure is working but everything else seems ok.

Also, since my local version is running on windows, there was a pathing issue in class-piklist.php in includes.

Here’s the fixed I made. Works great in 3.5.2 now, so take your time.

Marcus

Piklist Settings Page Error:

(IN)

/piklist/includes/class-piklist-workflow.php

Change line 200:
(FROM)
&& (!$post_type || ($post_type && (($post && $typenow == $post_type) || (!$post && $_REQUEST['post_type'] == $post_type))))

(TO)
&& (!$post_type || ($post_type && (($post && $typenow == $post_type) || (!$post && isset($_REQUEST['post_type']) && $_REQUEST['post_type'] == $post_type)))) // Edited

Windows Path Error:

(IN)

/piklist/includes/class-piklist.php

Change lines 136-137:
(FROM)

    self::$paths[$type] = $path;
    self::$urls[$type] = plugins_url() . substr($path, strrpos($path, '/'));

(TO)

    self::$paths[$type] = $path;
    $path = str_replace(chr(92), '/', $path); // Edited (windows path error)
    self::$urls[$type] = plugins_url() . substr($path, strrpos($path, '/'));

Misc Errors:

(IN)

/piklist/includes/class-piklist-form.php

Change line 767:
(FROM)
else if ($wp_taxonomies[$field['field']]->object_type[0] == 'user')

(TO)
else if (isset($wp_taxonomies[$field['field']]->object_type[0]) && $wp_taxonomies[$field['field']]->object_type[0] == 'user') // Edited

(IN)

/piklist/includes/class-piklist-form.php

Change line 422:
(FROM)
$meta = $meta[$key];

(TO)
$meta = isset($meta[$key])?$meta[$key]:0; // Edited

(IN)

/piklist/includes/class-piklist-cpt.php

Change line 343:
(FROM)
$post_type = $_REQUEST['post_type'];

(TO)
$post_type = isset($_REQUEST['post_type'])?$_REQUEST['post_type']:false; // Edited

(IN)

/piklist/includes/class-piklist-list-table.php

Change line 118:
(FROM)
$this->sortable_columns = $sortable_columns;

(TO)
$this->sortable_columns = isset($sortable_columns)?$sortable_columns:false; // Edited

Change line 125:
(FROM)
,'ajax' => $ajax

(TO)
,'ajax' => isset($ajax)?$ajax:false // Edited

Change line 78:

(FROM)
,'export' => $export

(TO)
,'export' => isset($export)?$export:true // Edited

Made a guess on var types when setting them.
Pretty sure I’m wrong, but didn’t take time to check. LOL

Marcus